-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reciprocal #17879
Reciprocal #17879
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @samthakur587,
I have requested some changes below, kindly try fixing the errors and request a review from me when the tests are passing!
Feel free to ask any questions.
Thanks! 🙂
@@ -276,3 +276,7 @@ def greater_than(self, y, name=None): | |||
@with_supported_dtypes({"2.5.0 and below": ("float32", "float64")}, "paddle") | |||
def rsqrt(self, name=None): | |||
return ivy.reciprocal(ivy.sqrt(self._ivy_array)) | |||
|
|||
@with_unsupported_dtypes({"2.5.0 and below": ("float16", "bfloat16")}, "paddle") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is failing for "int16" as it is not supported by paddle, you will probably come across more unsupported dtypes failures after adding this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @zaeemansari70 i am getting this error while testing the method. i am using pytest in vscode (wsl2-ubuntu-20.04). is there any different command to run test in cli.
thank you
hey @zaeemansari70 i changed the data type. now it,s passing all tests in my local. now its ready to merge. if any changes required please let me know. thank you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR looks good to be merged 👍
Kindly resolve the conflicts so I can merge your PR 🙂
hey @zaeemansari70 solved the merge conflict. Now it's Ready to merge. thank you |
Close #17736